shejialuo <shejialuo@xxxxxxxxx> writes: > "load_contents" would choose which way to load the content of the > "packed-refs". However, we cannot directly use this function when > checking the consistency due to we don't want to open the file. And we > also need to reuse the logic to avoid causing repetition. > > Let's create a new helper function "allocate_snapshot_buffer" to extract > the snapshot allocation logic in "load_contents" and update the > "load_contents" to align with the behavior. > > Suggested-by: Jeff King <peff@xxxxxxxx> > Suggested-by: Patrick Steinhardt <ps@xxxxxx> > Signed-off-by: shejialuo <shejialuo@xxxxxxxxx> > --- > refs/packed-backend.c | 54 +++++++++++++++++++++++++------------------ > 1 file changed, 32 insertions(+), 22 deletions(-) Trivially correct, cleanly done, and nicely described. Thanks.