On Mon, May 5, 2025 at 10:52 AM Patrick Steinhardt <ps@xxxxxx> wrote: > > We use a couple of global variables to assemble command line arguments > for subprocesses we execute in git-gc(1). All of these variables except > the one for git-repack(1) are only used in a single place though, so > they don't really add anything but confusion. > > Remove those variables. About the commit message it seems to me that it's missing "is", so maybe: "builtin/gc: remove global variables where it's trivial to do" or just: "builtin/gc: remove global variables where trivial to do" ?