On Fri, May 02, 2025 at 09:49:06AM -0700, Junio C Hamano wrote:
> Patrick Steinhardt <ps@xxxxxx> writes:
> >> @@ -656,6 +665,10 @@ int cmd_whatchanged(int argc,
> >> opt.def = "HEAD";
> >> opt.revarg_opt = REVARG_COMMITTISH;
> >> cmd_log_init(argc, argv, prefix, &rev, &opt, &cfg);
> >> +
> >> + if (!cfg.i_still_use_this)
> >> + you_still_use_that("git whatchanged");
> >> +
> >> if (!rev.diffopt.output_format)
> >> rev.diffopt.output_format = DIFF_FORMAT_RAW;
> >>
> >
> > I think it would help potential users of this command quite a bit if we
> > explicitly told them what the replacement is. So maybe we can extend
> > `you_still_use_that()` to accept an explanation?
>
> I doubt it. The reason why we remove something is not "because a
> better alternative exists"; it is "because everybody *HAS* switched
> to the better alternative". If we need to educate folks in this
> message, the plan to remove that command is still premature.
That's a fair point indeed.
Patrick
