Whoops. I'm seriously sorry for the coda on this updated commit message. I was testing out a different thing for something totally unrelated and was just adding random text to the end of the message that made me laugh. I didn't mean to submit this as the message after coming back to it after a few weeks. I promise this wasn't on purpose. (I'm not very good at Git) Related to the code change though, there was a comment that the message didn't match the patch somehow, but I'm afraid I don't understand how. Other than the cheeky mistaken addendum, it seems to me that the message still describes the new tests, no? Scott On Fri, Apr 25, 2025 at 9:17 AM Scott Chacon via GitGitGadget <gitgitgadget@xxxxxxxxx> wrote: > > From: Scott Chacon <schacon@xxxxxxxxx> > > The change to the bundle-uri unbundling refspec now includes tags, so this > adds a very, very simple test to make sure that tags in a bundle are > properly added to the cloned repository and will be included in ref > negotiation with the subsequent fetch. ok, now it's right. christ. > > Signed-off-by: Scott Chacon <schacon@xxxxxxxxx> > --- > t/t5558-clone-bundle-uri.sh | 30 ++++++++++++++++++++++++++++++ > 1 file changed, 30 insertions(+) > > diff --git a/t/t5558-clone-bundle-uri.sh b/t/t5558-clone-bundle-uri.sh > index 33a7009e9a2..9b211a626bd 100755 > --- a/t/t5558-clone-bundle-uri.sh > +++ b/t/t5558-clone-bundle-uri.sh > @@ -107,6 +107,36 @@ test_expect_success 'clone with file:// bundle' ' > test_cmp expect actual > ' > > +test_expect_success 'create bundle with tags' ' > + git init clone-from-tags && > + ( > + cd clone-from-tags && > + git checkout -b base && > + git checkout -b topic && > + > + test_commit A && > + git tag tag-A && > + git checkout -b base && > + git branch -d topic && > + test_commit B && > + > + git bundle create ALL.bundle --all && > + git bundle verify ALL.bundle > + ) > +' > + > +test_expect_success 'clone with tags bundle' ' > + git clone --bundle-uri="clone-from-tags/ALL.bundle" \ > + clone-from-tags clone-tags-path && > + > + git -C clone-from-tags for-each-ref --format="%(refname:lstrip=1)" \ > + >expect && > + git -C clone-tags-path for-each-ref --format="%(refname:lstrip=2)" \ > + refs/bundles >actual && > + > + test_cmp expect actual > +' > + > # To get interesting tests for bundle lists, we need to construct a > # somewhat-interesting commit history. > # > -- > gitgitgadget
