"Johannes Schindelin via GitGitGadget" <gitgitgadget@xxxxxxxxx> writes: > From: Johannes Schindelin <johannes.schindelin@xxxxxx> > > Since switching to `--vsenv`, the t7001-mv test consistently times out > after six hours in the CI builds on GitHub. This kind of waste is > inconsistent with my values. With mine too and I would presume everybody else's. I've been annoyed for a long time by one of those sharded Meson-Win test jobs that hang around until timeout. Thank you very much for addressing the issue. > The reason for this timeout is the test case 'nonsense mv triggers > assertion failure and partially updated index' in t7001-mv (which is > not even a regression test, but instead merely demonstrates a bug that > someone thought someone else should fix at some time). As the name > suggests, it triggers an assertion. The problem with this is that an > assertion on Windows, at least when run in Debug mode, will open a modal > dialog that patiently awaits some buttons to be clicked. Which never > happens in automated builds. Interesting. So another viable fix (no, I am not suggesting a counter-proposal, but asking a pure question to see if I understand the issue correctly) is to rewrite "assert(cond)" to "if (cond) BUG(...)" or something like that, so that it truly fails? > The solution is straight-forward: Just like the `win+VS` job already did > in forever, build in Release mode (where that modal assertion dialog is > never shown). OK. > Signed-off-by: Johannes Schindelin <johannes.schindelin@xxxxxx> > --- > ci(win+Meson): build in Release mode, avoiding t7001-mv hangs > > I was surprised to find this issue today, and that this had not been > addressed yet. > > Published-As: https://github.com/gitgitgadget/git/releases/tag/pr-1908%2Fdscho%2Fdont-let-win%2BMeson-hang-in-t7001-v1 > Fetch-It-Via: git fetch https://github.com/gitgitgadget/git pr-1908/dscho/dont-let-win+Meson-hang-in-t7001-v1 > Pull-Request: https://github.com/gitgitgadget/git/pull/1908 > > .github/workflows/main.yml | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/.github/workflows/main.yml b/.github/workflows/main.yml > index 83ca8e4182b..275240be5dc 100644 > --- a/.github/workflows/main.yml > +++ b/.github/workflows/main.yml > @@ -265,7 +265,7 @@ jobs: > run: pip install meson ninja > - name: Setup > shell: pwsh > - run: meson setup build --vsenv -Dperl=disabled -Dcredential_helpers=wincred > + run: meson setup build --vsenv -Dbuildtype=release -Dperl=disabled -Dcredential_helpers=wincred > - name: Compile > shell: pwsh > run: meson compile -C build > > base-commit: f65182a99e545d2f2bc22e6c1c2da192133b16a3
