On Wed, Apr 23, 2025 at 10:20:18AM -0700, Karthik Nayak wrote: > Patrick Steinhardt <ps@xxxxxx> writes: > > > Hi, > > > > this patch series contains a handful of cleanups to the object store > > subsystem: > > > > - A couple of definitions are moved out of "object-store.h" as they > > belong to other subsystems. > > > > - Some functions are dropped and/or renamed. > > > > - The biggest part is the removal of `repo_has_object_file()`. This > > function and its `_with_flags()` variant are marked as deprecated, > > with the replacement being `has_object()`. The benefit of that > > function is that it doesn't reload packfiles and doesn't fetch > > promisor objects by default so that it becomes more explicit when > > one really wants to do so. > > > > These cleanups are in preparation for getting rid of `the_repository` in > > "object-store.c". > > > > Apart from the few nits I mentioned, the series looks great! I must say > the split of commits was really nice to go through :) Thanks for your review! Patrick
