On 4/25/25 12:39 AM, Patrick Steinhardt wrote: > On Thu, Apr 24, 2025 at 08:13:29PM -0400, Eli Schwartz wrote: >> Principally motivated to handle an issue where these were failing to >> detect the system properly, on Solaris. > > I was expecting to also see my comments addressed around the one style > issue as well as the comment regarding `fs.exists()` being a bit too > magical (both mentioned in [1]). This is the only remaining item that > I'd like to see addressed, and other than that this series looks good to > me. I overlooked the style comment, will fix. Regarding the fs.exists I was worried that it would be repetitive and unwieldy but I think I found a good solution, as a bonus I can now handle strtoumax. -- Eli Schwartz
Attachment:
OpenPGP_signature.asc
Description: OpenPGP digital signature
