Aditya Garg <gargaditya08@xxxxxxxx> writes:
>> On 24 Apr 2025, at 12:33 AM, Junio C Hamano <gitster@xxxxxxxxx> wrote:
>>
>> Aditya Garg <gargaditya08@xxxxxxxx> writes:
>>
>>> @@ -230,6 +230,14 @@ or on the command line. If a username has been specified (with
>>> specified (with `--smtp-pass` or `sendemail.smtpPass`), then
>>> a password is obtained using 'git-credential'.
>>>
>>> +--smtp-passeval[=<command>]::
>>
>> Lose the pair of [] that marks the value optional. Compare it with,
>> say, --smtp-user that is described as:
>
> The value is not optional. It doesn't make sense to leave this empty right?
That is why I said "Lose the pair of []". IOW what we see above is
wrong and it should be something like
--smtp-passeval=<command>::
without the []. Just like --smtp-user takes a mandatory <user>,
like this:
>> --smtp-user=<user>::
>> Username for SMTP-AUTH. Default is ...
your "passeval" takes a mandatory <command>, hence =<command> should
NOT be enclosed in a pair of [].
