Re: [PATCH v4 0/5] meson: add corresponding target for Makefile's hdr-check

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi Karthik

On 22/04/2025 19:56, Karthik Nayak wrote:
Phillip Wood <phillip.wood123@xxxxxxxxx> writes:
Hi Karthik
The commands above omit anything that updates the package cache as we do
that anyway in install-dependencies.sh and we only really care about
getting some version of git installed here. It also uses apt-get to
match what we do in install-dependencies.sh


Seems like this is a no-go, since apt-get fails [1] without first
updating the package cache.

That's a shame, thanks for trying it

So I'm going to do that for all the
commands, which should also ensure that the package cache update in
'install-dependencies.sh' is mostly a no-op.

Fair enough

Thanks

Phillip
[1]: https://github.com/gitgitgadget/git/actions/runs/14598683520/job/40951070359?pr=1905

I also wonder if we should ditch the checkout action and use something like

      git clone --depth=1 --single-branch ${GITHUB_REF_NAME} \
	${GITHUB_SERVER_URL}/${GITHUB_REPOSITORY}.git

so that we know we will be building from a git repository.

Best Wishes

Phillip





[Index of Archives]     [Linux Kernel Development]     [Gcc Help]     [IETF Annouce]     [DCCP]     [Netdev]     [Networking]     [Security]     [V4L]     [Bugtraq]     [Yosemite]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux SCSI]     [Fedora Users]

  Powered by Linux