On Mon, Apr 21, 2025 at 01:51:49PM -0400, Eli Schwartz wrote: > Nowhere in the codebase do we otherwise check for strerror. Nowhere in > the codebase do we make use of -DNO_STRERROR. `strerror` is not a > networking function at all. > > We do utilize `hstrerror` though, which is a networking function we > should have been checking here. > > Signed-off-by: Eli Schwartz <eschwartz@xxxxxxxxxx> > --- > meson.build | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/meson.build b/meson.build > index 8fad10379a..1b7e55756b 100644 > --- a/meson.build > +++ b/meson.build > @@ -1088,7 +1088,7 @@ else > endif > libgit_dependencies += networking_dependencies > > -foreach symbol : ['inet_ntop', 'inet_pton', 'strerror'] > +foreach symbol : ['inet_ntop', 'inet_pton', 'hstrerror'] > if not compiler.has_function(symbol, dependencies: networking_dependencies) > libgit_c_args += '-DNO_' + symbol.to_upper() > endif Good catch and obviously correct, thanks! Patrick
