On Wed, Apr 09, 2025 at 07:36:47AM -0700, Elijah Newren wrote: > On Tue, Apr 8, 2025 at 3:37 AM Patrick Steinhardt <ps@xxxxxx> wrote: > > > > The `safe_create_leading_directories()` function and its relatives > > How is mkdir_in_gitdir() a relative of safe_create_leading_directories()? > > I assumed the relation was "called by", but there is no such > relationship. The rest of the patch looked fine, but I was puzzled > for a while trying to figure out what this relationship is. It's more of a sibling than a child/parent in this case, true. I still think it makes sense to move it around as it is rather generic in the functionality it provides and doesn't have anything to do with objects. Patrick