Todd Zullinger <tmz@xxxxxxxxx> writes: >> Most people won't run into this since if you have this installed in the >> standard locations, it should just work, and the zsh script does have >> logic to look for additional paths it may be under. I just wanted to >> mention it for info. > > I wonder whether it is proper to install the completion > scripts relative to git's $datadir by default. > > I think the default ought to use the pkg-config call to get > the completionsdir variable, as the zsh completion script > suggests. I am presuming that's something meson can do > rather trivially, just as it would do to find the compile > options for git's various build dependencies? > > I don't know if that becomes too messy to be worthwhile when > determining whether git is being installed by a normal user > in $HOME or by a privileged user in a system-wide prefix > like /usr. Yes, exactly. We left it out of what Makefile does for that exact reason. Distros will do what is best for their environment, and I do not think, unlike pkg-config used to figure out distro specific locations when doing a system-wide install, there is a location that will make everybody happy in the context of per-user installation. If we were to install these completion script from make or meson, I suspect that we'd eventually need a separate make variable or meson configuration item (whose default value can come from $datadir unless there is a better setting that already exists in our system) that is only used to specify the location completion script. Thanks.
