Re: [PATCH 1/1] t5601: modernize test by using test_path_is_file

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi!

Two things about your patch:

1. Given that you sent only a patch, you could do that without a cover
   letter, sending all the additional description that you want after 
   the scissors mark (the ---);

2. Your patch is adding the entire t5601.sh file. I could compare this
   with the file on the next branch, where I see that you indeed changed
   the line 69 for using `test_path_is_file`.

I suggest you to send a v2 containing only the changes that you did to
that file, instead of a patch that creates this entire file.




[Index of Archives]     [Linux Kernel Development]     [Gcc Help]     [IETF Annouce]     [DCCP]     [Netdev]     [Networking]     [Security]     [V4L]     [Bugtraq]     [Yosemite]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux SCSI]     [Fedora Users]

  Powered by Linux