On Wed, Apr 02, 2025 at 04:24:53PM -0500, Justin Tobler wrote: > On 25/03/31 10:41AM, Patrick Steinhardt wrote: > > diff --git a/t/unit-tests/t-reftable-block.c b/t/unit-tests/t-reftable-block.c > > index e36ed7ac576..c4ced39a73b 100644 > > --- a/t/unit-tests/t-reftable-block.c > > +++ b/t/unit-tests/t-reftable-block.c > > @@ -66,7 +66,8 @@ static void t_ref_block_read_write(void) > > block_source_from_buf(&source ,&block_data); > > reftable_block_init(&block, &source, 0, header_off, block_size, REFTABLE_HASH_SIZE_SHA1); > > > > - block_iter_seek_start(&it, &block); > > + block_iter_init(&it, &block); > > + block_iter_seek_start(&it); > > If I'm understanding correctly, `block_iter_init()` already invokes > `block_iter_seek_start()`. Why do we need to invoke > `block_iter_seek_start()` again? Ah, good catch, we don't. Will simplify. Patrick
