On Sun, Apr 6, 2025 at 8:15 AM Usman Akinyemi <usmanakinyemi202@xxxxxxxxx> wrote: > Since we already teach the `repo_config()` in "1a764cdbdc > (Merge branch 'ua/some-builtins-wo-the-repository', 2025-03-26)" > to allow `repo` to be NULL, no need to check if `repo` is NULL > before calling `repo_config()`. Okay, makes sense. However... By referencing only the merge commit in the above message, you force reviewers and future readers to chase down and locate the actual commit[*] which taught repo_config() to accept NULL for `repo`. To be more friendly to those people, you should help them by instead referencing the commit[*] itself. [*]: f29f1990b5 (config: teach repo_config to allow `repo` to be NULL, 2025-03-08) > Signed-off-by: Usman Akinyemi <usmanakinyemi202@xxxxxxxxx>
