On Tue, Apr 01, 2025 at 03:08:00PM -0700, Junio C Hamano wrote: > Patrick Steinhardt <ps@xxxxxx> writes: > > > + for (size_t i = 0; i < nrecords; i++) { > > + records[i].value_type = REFTABLE_REF_VAL1, > > -Wcomma,error Hah, good that we've now got the warning. > > + records[i].refname = xstrfmt("refs/heads/branch-%03"PRIuMAX, (uintmax_t) i); > > + } > > An overlong line. Thanks for these two, fixed both of them locally. Will wait a bit for more reviews though before sending out a new version. Patrick