If we want to check the range of an array index, it makes much more sense to do it before accessing the corresponding array element, not afterwards. There are two more instances of this in the clar code, fixes for which I offer in https://github.com/clar-test/clar/pull/115. Johannes Schindelin (2): diff: check range before dereferencing an array element read-cache: check range before dereferencing an array element diff.c | 2 +- read-cache.c | 4 ++-- 2 files changed, 3 insertions(+), 3 deletions(-) base-commit: 683c54c999c301c2cd6f715c411407c413b1d84e Published-As: https://github.com/gitgitgadget/git/releases/tag/pr-1887%2Fdscho%2Frange-check-array-index-before-access-v1 Fetch-It-Via: git fetch https://github.com/gitgitgadget/git pr-1887/dscho/range-check-array-index-before-access-v1 Pull-Request: https://github.com/gitgitgadget/git/pull/1887 -- gitgitgadget
