On Mon, Mar 24, 2025 at 3:18 AM Johannes Sixt <j6t@xxxxxxxx> wrote: > > > You have now managed to avoid the "No newline at end of file", but have > added a blank line instead. Not a big deal, but unconventional. > I missed the opportunity to reply to the original patch on this front, but here's the information I usually give out: - VS Code's default settings do not respect POSIX end-of-file newline standards, so you should probably change them [1] - There's a similar setting for Intellij IDEA [2] and Vim [3], but they might have saner defaults (Vim certainly does) - If your editor or IDE picks up on editorconfig settings, you'll be able to avoid this - Git can warn you with diff or show saying "No newline at end of file," so a careful self-review also catches these. [1]: https://stackoverflow.com/q/44704968/4400820 [2]: https://stackoverflow.com/q/16761227/4400820 [3]: https://vimhelp.org/options.txt.html#%27endofline%27 -- D. Ben Knoble
