Re: [PATCH v2] shell: allow overriding built-in commands

[Ayman Bagabas <ayman.bagabas@xxxxxxxxx>]

> On Mar 23, 2025, at 4:11 AM, Chris Torek <chris.torek@xxxxxxxxx> wrote:
> 
> I'm not at all sure about any security implications, but aside from that, I
> suspect this:
> 
> On Sat, Mar 22, 2025 at 5:13 PM Ayman Bagabas via GitGitGadget
> <gitgitgadget@xxxxxxxxx> wrote:
>> +               if (!access(full_cmd, F_OK)) {
> 
> should use X_OK rather than F_OK.

Good catch!

Shouldn't we also check for both F_OK?

> 
> Chris