Re: [PATCH] [RFC] shell: allow overriding built-in commands

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Sat, Mar 22, 2025 at 3:02 AM Ayman Bagabas via GitGitGadget
<gitgitgadget@xxxxxxxxx> wrote:
>
> From: Ayman Bagabas <ayman.bagabas@xxxxxxxxx>
>
> This patch allows overriding built-in commands by placing a script
> with the same name under git-shell-commands directory.
>
> This is useful for users who want to extend the built-in commands
> without replacing the original command binary. For instance, a user
> wanting to allow only a subset of users to run the git-receive-pack
> can override the command with a script that checks the user and
> calls the original command if the user is allowed.

Sounds like it'd open a window to generating numerous security
vulnerabilities, break git's own commands that exec another git
subprocess (e.g. git-stash), make debugging git bug reports harder,
and likely break programs that use plumbing commands.

I'd rather we didn't.





[Index of Archives]     [Linux Kernel Development]     [Gcc Help]     [IETF Annouce]     [DCCP]     [Netdev]     [Networking]     [Security]     [V4L]     [Bugtraq]     [Yosemite]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux SCSI]     [Fedora Users]

  Powered by Linux