On Wed, Mar 12, 2025 at 4:18 PM Junio C Hamano <gitster@xxxxxxxxx> wrote: > > Elijah Newren <newren@xxxxxxxxx> writes: > > > But it might be worth mentioning that having side-effects in > > assertions is a huge no-no, and I understand that when folks have to > > debug one of those (I had to in a separate project years ago which was > > kind of nasty), that they sometimes jump to the conclusion that > > assertions are bad. > > Yes, assert() invites such mistakes. Why not avoid them when there > are better alternatives like "if (condition) BUG()"? I mean, I just gave my reasons above which you snipped out. But if you feel it is important for folks to move away from assert(), would you like to see someone create a better alternative to assert, such as BUG_ON(condition), so that they have reason to want to switch?
