Re: [PATCH 1/9] t5702: fix typo in test name

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Wed, Mar 12, 2025 at 05:30:03PM -0400, Taylor Blau wrote:

> On Sat, Mar 08, 2025 at 10:01:23PM -0500, Jeff King wrote:
> > Signed-off-by: Jeff King <peff@xxxxxxxx>
> > ---
> >  t/t5702-protocol-v2.sh | 2 +-
> >  1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/t/t5702-protocol-v2.sh b/t/t5702-protocol-v2.sh
> > index d3df81e785..cea8f92a3d 100755
> > --- a/t/t5702-protocol-v2.sh
> > +++ b/t/t5702-protocol-v2.sh
> > @@ -665,7 +665,7 @@ test_expect_success 'even with handcrafted request, filter does not work if not
> >  	test-tool -C server serve-v2 --stateless-rpc <in >/dev/null
> >  '
> >
> > -test_expect_success 'default refspec is used to filter ref when fetchcing' '
> > +test_expect_success 'default refspec is used to filter ref when fetching' '
> 
> Maybe I am not seeing enough of the context below to know for sure, but
> 
>     s/ref/&s
> 
> ?

Possibly.

I think you could read it as "it should filter refs" (which it obviously
should). But you could also read it as "it should filter some singular
ref that we do not expect to find in the result". Of course the test
itself seems to just snoop on the protocol conversation, which I guess
is more like the first reading.

I didn't really want to get into word-smithing the test titles. I just
couldn't handle seeing that typo over and over while working on adjacent
tests.

-Peff




[Index of Archives]     [Linux Kernel Development]     [Gcc Help]     [IETF Annouce]     [DCCP]     [Netdev]     [Networking]     [Security]     [V4L]     [Bugtraq]     [Yosemite]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux SCSI]     [Fedora Users]

  Powered by Linux