On Tue, Feb 25, 2025 at 8:36 AM Elijah Newren <newren@xxxxxxxxx> wrote: > > On Mon, Feb 24, 2025 at 6:28 AM Christian Couder > <christian.couder@xxxxxxxxx> wrote: > [...snip...] > > diff --git a/Documentation/git-fast-export.adoc b/Documentation/git-fast-export.adoc > > index 1b19f17b78..8750dd150b 100644 > > --- a/Documentation/git-fast-export.adoc > > +++ b/Documentation/git-fast-export.adoc > > @@ -43,6 +43,17 @@ they will be exported, but you will see a warning. 'verbatim' and > > transformation affecting tags will be performed, or if you do not > > care that the resulting tag will have an invalid signature. > > > > +--signed-commits=(verbatim|warn-verbatim|warn-strip|strip|abort):: > > + Specify how to handle signed commits. Behaves exactly as > > + '--signed-tags', but for commits. > > Should this also explicitly call out that the default is abort? Yeah, that might help, so "Default is 'abort'." has been added in the next version. > Yes, > I know that... > > > ++ > > +Earlier versions this command that did not have '--signed-commits' > > +behaved as if '--signed-commits=strip'. As an escape hatch for users > > +of tools that call 'git fast-export' but do not yet support > > +'--signed-commits', you may set the environment variable > > +'FAST_EXPORT_SIGNED_COMMITS_NOABORT=1' in order to change the default > > +from 'abort' to 'warn-strip'. > > ...this paragraph implies abort is the default, but I imagine we > eventually drop this paragraph, but > it'd still be useful to have the default called out. We could still rely on the fact that the doc above says "Behaves exactly as '--signed-tags', but for commits." and the default for '--signed-tags' is 'abort', but I agree that it can still help to spell it out. > [...snip...] > > > @@ -611,6 +615,44 @@ static void anonymize_ident_line(const char **beg, const char **end) > > *end = out->buf + out->len; > > } > > > > +/* > > + * find_commit_multiline_header is similar to find_commit_header, > > + * except that it handles multi-line headers, rathar than simply > > s/rathar/rather/ Fixed in the next version. Thanks.
