> Is this a recent regression? Blaming these two line ranges ... > > > > > [1] https://github.com/openbsd/src/blob/6a403588e27467d1f271831ca1de62a3befea6a0/include/stdio.h#L236-L237 > > [2] https://github.com/openbsd/src/blob/6a403588e27467d1f271831ca1de62a3befea6a0/sys/sys/cdefs.h#L299-L302 > > ... in the OpenBSD repository says they haven't changed for many > years, and I am wondering what triggered this all of a sudden. > > If we know how we used to have no issue, in addition to how we now > have issue with the current OpenBSD (which you outlined very well > above), and when the situation changed, please add to the proposed > log message. That would help people on OpenBSD to decide when they > want to upgrade their copy of Git. The thing that changed was the release of clang 19, which enabled the mentioned Werror by default. This is showing up now because I am experimenting with building software for OpenBSD through nixpkgs, which prefers the most recent version of everything. I am not sure what of this is appropriate to add to the commit message. > Also, I am wondering if this "A and B needs only 500 but C needs > 600, hence require 600 from all three" is a healthy thing to > continue. How bad it would become to split C at least from A and B, > to give it an independent status, i.e. leaving the above line as-is, > but insert > > #elif defined(OPENBSD) > #define _XOPEN_SOURCE 700 > > before the existing catchall > "#elif !defined(__APPLE__) && !defined(__FreeBSD__) ..." line? I can give it a shot.
