On Thu, Feb 20, 2025 at 09:29:55AM +0100, Seyi Kuforiji wrote: > diff --git a/t/unit-tests/unit-test.h b/t/unit-tests/unit-test.h > index 85e5d6a948..ebed51212f 100644 > --- a/t/unit-tests/unit-test.h > +++ b/t/unit-tests/unit-test.h > @@ -8,3 +8,22 @@ > snprintf(desc, sizeof(desc), fmt, __VA_ARGS__); \ > clar__fail(__FILE__, __func__, __LINE__, "Test failed.", desc, 1); \ > } while (0) > + > +/* > + * Convert arbitrary hex string to object_id. > + * For example, passing "abc12" will generate > + * "abc1200000000000000000000000000000000000" hex of length 40 for SHA-1 and > + * create object_id with that. > + * WARNING: passing a string of length more than the hexsz of respective hash > + * algo is not allowed. The hash algo is decided based on GIT_TEST_DEFAULT_HASH > + * environment variable. > + */ > +void cl_parse_any_oid(const char *s, struct object_id *oid); Nit: let's add a space between the function decarations. I'd also add a blank line into the comments before the "For example" paragraph and after it to make it easier to parse. Patrick
