Hi,
this patch series removes the dependency on `the_repository` from the
"path" subsystem. The series is structured as follows:
- Patches 1 to 5 unifyf the interfaces that can be used to retrieve
repository paths (gitdir, commondir, workdir and submodule paths)
and adapts callers accodringly.
- Patches 6 to 12 drop repository path functions that had an implicit
dependency on `the_repository`.
- Patches 13 to 16 refactor "path.c"-internal code to stop depending
on `the_repository`.
Thanks!
Patrick
---
Patrick Steinhardt (16):
path: refactor `repo_common_path()` family of functions
path: refactor `repo_git_path()` family of functions
path: refactor `repo_worktree_path()` family of functions
submodule: refactor `submodule_to_gitdir()` to accept a repo
path: refactor `repo_submodule_path()` family of functions
path: drop unused `strbuf_git_path()` function
path: drop `git_pathdup()` in favor of `repo_git_path()`
path: drop `git_path_buf()` in favor of `repo_git_path_replace()`
worktree: return allocated string from `get_worktree_git_dir()`
path: drop `git_common_path()` in favor of `repo_common_path()`
rerere: let `rerere_path()` write paths into a caller-provided buffer
path: drop `git_path()` in favor of `repo_git_path()`
repo-settings: introduce function to clear struct
environment: move access to "core.hooksPath" into repo settings
environment: move access to "core.sharedRepository" into repo settings
path: adjust last remaining users of `the_repository`
bisect.c | 2 +-
branch.c | 7 +-
builtin/am.c | 2 +-
builtin/clone.c | 4 +-
builtin/commit.c | 8 +-
builtin/config.c | 8 +-
builtin/fast-import.c | 4 +-
builtin/fsck.c | 10 ++-
builtin/gc.c | 25 ++++--
builtin/init-db.c | 8 +-
builtin/log.c | 6 +-
builtin/notes.c | 9 ++-
builtin/rebase.c | 2 +-
builtin/receive-pack.c | 4 +-
builtin/remote.c | 6 +-
builtin/replace.c | 2 +-
builtin/rerere.c | 11 ++-
builtin/rev-parse.c | 6 +-
builtin/submodule--helper.c | 4 +-
builtin/tag.c | 2 +-
builtin/worktree.c | 43 +++++++---
commit-graph.c | 2 +-
compat/precompose_utf8.c | 6 +-
config.c | 5 --
copy.c | 4 +-
dir.c | 2 +-
editor.c | 6 +-
environment.c | 27 -------
environment.h | 11 ---
hook.c | 3 +-
http-backend.c | 2 +-
loose.c | 8 +-
midx-write.c | 2 +-
notes-merge.c | 26 +++---
object-file.c | 14 ++--
pack-bitmap-write.c | 2 +-
pack-write.c | 10 ++-
path.c | 166 +++++++++++++++++++++++++++-----------
path.h | 191 ++++++++++++--------------------------------
reachable.c | 6 +-
read-cache.c | 26 ++++--
refs.c | 6 +-
refs/files-backend.c | 10 +--
refs/reftable-backend.c | 10 +--
remote.c | 21 ++---
repo-settings.c | 44 +++++++++-
repo-settings.h | 14 ++++
repository.c | 6 +-
rerere.c | 101 ++++++++++++++++-------
rerere.h | 3 +-
revision.c | 7 +-
server-info.c | 2 +-
setup.c | 70 ++++++++--------
shallow.c | 4 +-
submodule.c | 15 ++--
submodule.h | 3 +-
t/helper/test-ref-store.c | 7 +-
tempfile.c | 4 +-
tmp-objdir.c | 17 ++--
worktree.c | 49 ++++++++----
worktree.h | 2 +-
wt-status.c | 42 ++++++----
62 files changed, 639 insertions(+), 490 deletions(-)
---
base-commit: bc204b742735ae06f65bb20291c95985c9633b7f
change-id: 20250204-b4-pks-path-drop-the-repository-9ed0f9956361
