On Fri, Aug 15, 2025 at 05:16:51PM +0200, Amir Goldstein wrote: > On Fri, Aug 15, 2025 at 4:47 PM Zorro Lang <zlang@xxxxxxxxxx> wrote: > > > > When we runs overlay/005 on a system without xfs module, it always > > fails as "unknown filesystem type xfs", due to this case require xfs > > to be the underlying fs explicitly: > > > > $MKFS_XFS_PROG -f -n ftype=1 $upper_loop_dev >>$seqres.full 2>&1 > > > > So notrun this case if the underlying fs isn't 'xfs'. > > It would have been better if instead of mkfs.xfs, we would have > used a helper to format $upper_loop_dev as $OVL_BASE_FSTYP > > But this is easier, so unless anybody wants to take on the better fix > > Acked-by: Amir Goldstein <amir73il@xxxxxxxxx> Thanks Amir, No matter what kinds of underlying fs are all good? I saw this case use: $MKFS_XFS_PROG -f -n ftype=1 $upper_loop_dev So I thought it need the xfs ftype feature :-D > > Thanks, > Amir. > > > > > Reported-by: Philip Daly <pdaly@xxxxxxxxxx> > > Signed-off-by: Zorro Lang <zlang@xxxxxxxxxx> > > --- > > tests/overlay/005 | 1 + > > 1 file changed, 1 insertion(+) > > > > diff --git a/tests/overlay/005 b/tests/overlay/005 > > index 4c11d5e1b..d396b5cb2 100755 > > --- a/tests/overlay/005 > > +++ b/tests/overlay/005 > > @@ -31,6 +31,7 @@ _cleanup() > > # them explicity after test. > > _require_scratch_nocheck > > _require_loop > > +[ "$OVL_BASE_FSTYP" = "xfs" ] || _notrun "The underlying fs should be xfs" > > > > # Remove all files from previous tests > > _scratch_mkfs > > -- > > 2.49.0 > > > > >
