On 8/25/25 11:25, Ojaswin Mujoo wrote:
On Wed, Aug 20, 2025 at 08:15:03AM +0000, Nirjhar Roy (IBM) wrote:
Some of the btrfs and generic tests are written with 4k block/node size in mind.
This patch fixes some of those tests to be compatible with other block/node sizes too.
We caught these bugs while running the auto group tests on btrfs with large
block/node sizes.
[v2] -> v3
1. Added RBs by Qu Wenruo in btrfs/{301, 137}
2. Updated the commit message of generic/563 with a more detailed explanation
by Qu Wenrou.
3. Reverted by block size from 64k to 4k while filling the filesystem with dd
for test generic/274.
Hi Nirjhar,
The changes look good. With the commit message typo fixed for
generic/563, feel free to add
Reviewed-by: Ojaswin Mujoo <ojaswin@xxxxxxxxxxxxx>
Thanks. Added the RBs, fixed some typos and sent the final [v4].
[v4]
https://lore.kernel.org/all/cover.1756101620.git.nirjhar.roy.lists@xxxxxxxxx/
--NR
Regards,
ojaswin
[v1] -> [v2]:
1. Removed the patch for btrfs/200 of [v1] - need more analysis on this.
2. Removed the first 2 patches of [v1] which introduced 2 new helper functions
3. btrfs/{137,301} and generic/274 - Instead of scaling the test dynamically
based on the underlying disk block size, I have hardcoded the pwrite blocksizes
and offsets to 64k which is aligned to all underlying fs block sizes <= 64.
4. For generic/563 - Doubled the iosize instead of btrfs specific hack to cover
for btrfs write ranges.
5. Updated the commit messages
[v1] - https://lore.kernel.org/all/cover.1753769382.git.nirjhar.roy.lists@xxxxxxxxx/
[v2] - https://lore.kernel.org/all/cover.1755604735.git.nirjhar.roy.lists@xxxxxxxxx/
Nirjhar Roy (IBM) (4):
btrfs/301: Make the test compatible with all the supported block sizes
generic/274: Make the pwrite block sizes and offsets to 64k
btrfs/137: Make this test compatible with all supported block sizes
generic/563: Increase the iosize to to cover for btrfs
tests/btrfs/137 | 11 ++++----
tests/btrfs/137.out | 66 ++++++++++++++++++++++-----------------------
tests/btrfs/301 | 2 +-
tests/generic/274 | 8 +++---
tests/generic/563 | 2 +-
5 files changed, 45 insertions(+), 44 deletions(-)
--
2.34.1
--
Nirjhar Roy
Linux Kernel Developer
IBM, Bangalore
