On Thu, Jul 24, 2025 at 09:25:14AM +0200, Christoph Hellwig wrote: > This reverts commit 68c9ac2ad74ba31c02275fcbb11d1cf90f0435b1. > > The test does not actually use the xfs_io shutdown functionality, > and it does not use the scatch device. Adding this checks causes > it to fail for setups that do not use SCRATCH_DEV at all. > > Signed-off-by: Christoph Hellwig <hch@xxxxxx> > --- > tests/generic/730 | 1 - > 1 file changed, 1 deletion(-) > > diff --git a/tests/generic/730 b/tests/generic/730 > index 6b5d319675f7..6251980e33e1 100755 > --- a/tests/generic/730 > +++ b/tests/generic/730 > @@ -29,7 +29,6 @@ _require_scsi_debug > size=$(_small_fs_size_mb 256) > SCSI_DEBUG_DEV=`_get_scsi_debug_dev 512 512 0 $size` > test -b "$SCSI_DEBUG_DEV" || _notrun "Failed to initialize scsi debug device" > -SCRATCH_DEV=$SCSI_DEBUG_DEV _require_scratch_shutdown About why this case need "shutdown": https://lore.kernel.org/fstests/PUZPR04MB63169A8C1008035BB2D104568166A@xxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxx/ So looks like we'd better to notrun if shutdown isn't supported by fs on SCSI_DEBUG_DEV. But if think "_require_scratch_shutdown" is a problem, maybe we can avoid using _scratch_ things, use a local function to check shutdown on SCSI_DEBUG_DEV manually, and notrun if it's not supported? BTW, can I ask why do you need to test with TEST_DEV only :) Although SCRATCH_DEV is optional (README says), I think nearly all testers test with SCRATCH_DEV. Thanks, Zorro > echo "SCSI debug device $SCSI_DEBUG_DEV" >>$seqres.full > > run_check _mkfs_dev $SCSI_DEBUG_DEV > -- > 2.47.2 > >
