Looks like there's only one mount option "quota=..." for gfs2. And I didn't
find a description about project quota, so
1. What will gfs2 do if there's a "prjquota" or "pquota"?
2. Do you need to replace "noquota" with "quota=off"?
3. And "quota" to "quota=on" ?
4. Have you tried your patch on gfs2, can all quota related generic cases pass/notrun
on gfs2?
BTW, in this function you can see:
# ext4 doesn't _do_ "-o pquota/prjquota" because reasons
# Switch it to "quota" to enable mkfs-time pquota
if [[ "$FSTYP" == ext[234] ]]; then
OPTS=`echo $OPTS \
| sed -e 's/\bpquota/quota/g' \
-e 's/prjquota/quota/g'`
# ocfs2 doesn't support "-o projquota"
elif [[ "$FSTYP" == ocfs2 ]]; then
OPTS=`echo $OPTS | sed -e 's/prjquota//g'`
fi
please move your gfs2 specific codes here ^^, and give it enough comments.
> +
> # Replace any user defined quota options
> # with the quota option that we want.
> # Simplest to do this rather than delete existing ones first because
> @@ -300,6 +306,7 @@ _qmount_option()
> -e 's/\bpquota/QUOTA/g' \
> -e 's/prjquota/QUOTA/g' \
> -e 's/noquota/QUOTA/g' \
> + -e 's/quota=[^, ]*/QUOTA/g' \
I think you might need a word boundary, e.g. "\bquota=..."
Thanks,
Zorro
> -e 's/quota/QUOTA/g' \
> -e 's/uqnoenforce/QUOTA/g' \
> -e 's/gqnoenforce/QUOTA/g' \
> --
> 2.48.1
>
>
