On Fri, Jun 13, 2025 at 07:56:55AM -0700, Darrick J. Wong wrote:
> On Fri, Jun 13, 2025 at 08:14:17AM +0200, Christoph Hellwig wrote:
> > Commit 3ae8a19f97d0 ("generic/740: enable by default") moved these checks
> > down accidentally. Move them back up to make the test exit gracefully
> > when no scratch device is provided.
> >
> > Signed-off-by: Christoph Hellwig <hch@xxxxxx>
>
> Looks fine,
> Reviewed-by: "Darrick J. Wong" <djwong@xxxxxxxxxx>
Weird, I didn't get this patch in my mailbox, I just got your reply.
>
> --D
>
> > ---
> > tests/generic/740 | 6 +++---
> > 1 file changed, 3 insertions(+), 3 deletions(-)
> >
> > diff --git a/tests/generic/740 b/tests/generic/740
> > index c0a634f2302b..ce55200f7bc3 100755
> > --- a/tests/generic/740
> > +++ b/tests/generic/740
> > @@ -21,13 +21,13 @@ _exclude_fs jfs
> > _exclude_fs ocfs2
> > _exclude_fs udf
> >
> > +_require_scratch_nocheck
> > +_require_no_large_scratch_dev
> > +
> > _require_block_device "${SCRATCH_DEV}"
> > # not all the FS support zoned block device
> > _require_non_zoned_device "${SCRATCH_DEV}"
> >
> > -_require_scratch_nocheck
> > -_require_no_large_scratch_dev
This change looks better than latest version, thanks for fixing it :)
Reviewed-by: Zorro Lang <zlang@xxxxxxxxxx>
> > -
> > echo "Silence is golden."
> > for fs in `echo ${MKFS_PROG}.* | sed -e "s:${MKFS_PROG}.::g"`
> > do
> > --
> > 2.47.2
> >
> >
>
