On Fri, Jun 13, 2025 at 09:52:10PM +0800, Yuezhang Mo wrote: > For file systems that do not support chown, such as exfat, > running this test does not make sense and should be skipped. /me scans the test, only sees stuff about idmap... If I read this correctly, exfat doesn't assign individual files a user/group id, so idmapping (which is what this test really does) has very little meaning, because every file is "owned" either by the value provided by the uid= mount option, or the uid of the mount(8) process. Therefore g/633 can't test remapping of select uids. If that's the case then Reviewed-by: "Darrick J. Wong" <djwong@xxxxxxxxxx> --D > Signed-off-by: Yuezhang Mo <Yuezhang.Mo@xxxxxxxx> > Reviewed-by: Friendy Su <friendy.su@xxxxxxxx> > --- > tests/generic/633 | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/tests/generic/633 b/tests/generic/633 > index b683c427..d75d4dc8 100755 > --- a/tests/generic/633 > +++ b/tests/generic/633 > @@ -13,6 +13,7 @@ _begin_fstest auto quick atime attr cap idmapped io_uring mount perms rw unlink > . ./common/filter > > _require_test > +_require_chown > > echo "Silence is golden" > > -- > 2.25.1 > >
