On Thu, Jun 12, 2025 at 11:24:34PM +0000, Catherine Hoang wrote: > > > On Jun 12, 2025, at 12:06 AM, Ojaswin Mujoo <ojaswin@xxxxxxxxxxxxx> wrote: > > > > On Wed, Jun 11, 2025 at 06:57:07PM -0700, Catherine Hoang wrote: > >> Simple tests of various atomic write requests and a (simulated) hardware > >> device. > >> > >> The first test performs basic multi-block atomic writes on a scsi_debug device > >> with atomic writes enabled. We test all advertised sizes between the atomic > >> write unit min and max. We also ensure that the write fails when expected, such > >> as when attempting buffered io or unaligned directio. > >> > >> The second test is similar to the one above, except that it verifies multi-block > >> atomic writes on actual hardware instead of simulated hardware. The device used > >> in this test is not required to support atomic writes. > >> > >> The final two tests ensure multi-block atomic writes can be performed on various > >> interweaved mappings, including written, mapped, hole, and unwritten. We also > >> test large atomic writes on a heavily fragmented filesystem. These tests are > >> separated into reflink (shared) and non-reflink tests. > >> > >> Signed-off-by: "Darrick J. Wong" <djwong@xxxxxxxxxx> > >> Signed-off-by: Catherine Hoang <catherine.hoang@xxxxxxxxxx> > >> --- > > > > <snip> > > > > Okay after running some of these tests on my setup, I have a few > > more questions regarding g/1225. > > > >> diff --git a/tests/generic/1225 b/tests/generic/1225 > >> new file mode 100755 > >> index 00000000..f2dea804 > >> --- /dev/null > >> +++ b/tests/generic/1225 > >> @@ -0,0 +1,128 @@ > >> +#! /bin/bash > >> +# SPDX-License-Identifier: GPL-2.0 > >> +# Copyright (c) 2025 Oracle. All Rights Reserved. > >> +# > >> +# FS QA Test 1225 > >> +# > >> +# basic tests for large atomic writes with mixed mappings > >> +# > >> +. ./common/preamble > >> +_begin_fstest auto quick rw atomicwrites > >> + > >> +. ./common/atomicwrites > >> +. ./common/filter > >> +. ./common/reflink > >> + > >> +_require_scratch > >> +_require_atomic_write_test_commands > >> +_require_scratch_write_atomic_multi_fsblock > >> +_require_xfs_io_command pwrite -A > > > > I think this is already covered in _require_atomic_write_test_commands > > > >> + > >> +_scratch_mkfs_sized $((500 * 1048576)) >> $seqres.full 2>&1 > >> +_scratch_mount > >> + > >> +file1=$SCRATCH_MNT/file1 > >> +file2=$SCRATCH_MNT/file2 > >> +file3=$SCRATCH_MNT/file3 > >> + > >> +touch $file1 > >> + > >> +max_awu=$(_get_atomic_write_unit_max $file1) > >> +test $max_awu -ge 262144 || _notrun "test requires atomic writes up to 256k" > > > > Is it possible to keep the max_awu requirement to maybe 64k? The reason > > I'm asking is that in 4k bs ext4 with bigalloc, having cluster size more > > than 64k is actually experimental so I don't think many people would be > > formatting with 256k cluster size and would miss out on running this > > test. Infact if i do set the cluster size to 256k I'm running into > > enospc in the last enospc scenario of this test, whereas 64k works > > correctly). > > > > So just wondering if we can have an awu_max of 64k here so that more > > people are easily able to run this in their setups? > > Yes, this can be changed to 64k. I think only one of the tests need > 256k writes, but it looks like that can be changed to 64k as well. > Thanks for the comments! Awesome, thanks! Regards, ojaswin
