Catherine Hoang <catherine.hoang@xxxxxxxxxx> writes:
> From: "Darrick J. Wong" <djwong@xxxxxxxxxx>
>
> Fix some bugs when detecting the atomic write geometry, record what
> atomic write geometry we're testing each time through the loop, and
> create a group for atomic writes tests.
>
> Signed-off-by: "Darrick J. Wong" <djwong@xxxxxxxxxx>
> Signed-off-by: Catherine Hoang <catherine.hoang@xxxxxxxxxx>
> ---
> common/rc | 4 ++--
> doc/group-names.txt | 1 +
> tests/generic/765 | 25 ++++++++++++++++++++++++-
> 3 files changed, 27 insertions(+), 3 deletions(-)
>
> diff --git a/common/rc b/common/rc
> index bc8dabc5..3a70c707 100644
> --- a/common/rc
> +++ b/common/rc
> @@ -5442,13 +5442,13 @@ _get_atomic_write_unit_min()
> _get_atomic_write_unit_max()
> {
> $XFS_IO_PROG -c "statx -r -m $STATX_WRITE_ATOMIC" $1 | \
> - grep atomic_write_unit_max | grep -o '[0-9]\+'
> + grep -w atomic_write_unit_max | grep -o '[0-9]\+'
> }
>
> _get_atomic_write_segments_max()
> {
> $XFS_IO_PROG -c "statx -r -m $STATX_WRITE_ATOMIC" $1 | \
> - grep atomic_write_segments_max | grep -o '[0-9]\+'
> + grep -w atomic_write_segments_max | grep -o '[0-9]\+'
> }
>
> _require_scratch_write_atomic()
> diff --git a/doc/group-names.txt b/doc/group-names.txt
> index f510bb82..1b38f73b 100644
> --- a/doc/group-names.txt
> +++ b/doc/group-names.txt
> @@ -12,6 +12,7 @@ acl Access Control Lists
> admin xfs_admin functionality
> aio general libaio async io tests
> atime file access time
> +atomicwrites RWF_ATOMIC testing
NIT: I wish we could have a shorter name for this? atomicwr or awio (Atomic write I/O)
Either ways, the changes looks logical to me. It's good to have these
various atomic units in $seqres.full file for later debugging.
Please feel free to add:
Reviewed-by: Ritesh Harjani (IBM) <ritesh.list@xxxxxxxxx>
-ritesh
