On Fri, Feb 28, 2025 at 01:55:22PM +0800, Anand Jain wrote: > Checks if the sysfs attribute sanitizes arguments and verifies > input syntax. > > Signed-off-by: Anand Jain <anand.jain@xxxxxxxxxx> > --- > tests/btrfs/329 | 19 +++++++++++++++++++ > tests/btrfs/329.out | 19 +++++++++++++++++++ > 2 files changed, 38 insertions(+) > create mode 100755 tests/btrfs/329 > create mode 100644 tests/btrfs/329.out > > diff --git a/tests/btrfs/329 b/tests/btrfs/329 > new file mode 100755 > index 000000000000..48849ac82706 > --- /dev/null > +++ b/tests/btrfs/329 > @@ -0,0 +1,19 @@ > +#! /bin/bash > +# SPDX-License-Identifier: GPL-2.0 > +# Copyright (c) 2025 Oracle. All Rights Reserved. > +# > +# FS QA Test 329 > +# > +# Verify sysfs knob input syntax for read_policy round-robin > +# > +. ./common/preamble > +_begin_fstest auto quick > + > +. ./common/sysfs > +. ./common/filter > + > +_require_fs_sysfs_attr_policy $TEST_DEV read_policy round-robin > +verify_sysfs_syntax $TEST_DEV read_policy round-robin 4096 Please change the verify_sysfs_syntax to _verify_sysfs_syntax after you update the patch 3/5. And just be curious, do we need to make sure the $TEST_DEV is mounted before testing the sysfs' read_policy of $TEST_DEV? For example, calls _require_test Thanks, Zorro > + > +status=0 > +exit > diff --git a/tests/btrfs/329.out b/tests/btrfs/329.out > new file mode 100644 > index 000000000000..eff7573adb6a > --- /dev/null > +++ b/tests/btrfs/329.out > @@ -0,0 +1,19 @@ > +QA output created by 329 > +Invalid argument > +Invalid argument > +Invalid argument > +Invalid argument > +Invalid argument > +Invalid argument > +Invalid argument > +Invalid argument > +Invalid argument > +Invalid argument > +Invalid argument > +Invalid argument > +Invalid argument > +Invalid argument > +Invalid argument > +Invalid argument > +Invalid argument > +Invalid argument > -- > 2.47.0 > >
