https://bugzilla.redhat.com/show_bug.cgi?id=2395053 --- Comment #4 from Fabio Valentini <decathorpe@xxxxxxxxx> --- Thank you for the review! > - The version is not quite the latest (1.0.221 instead of 1.0.225). This is > not > worrisome. I am sure you will update the serde packages to the latest > versions eventually. Yes - 1.0.221 was just the latest version when I submitted this for review. It looks like this reorganization is still causing a lot of churn in serde upstream (and projects that depend on serde) so there are new releases being published quite frequently (more than daily). > - The Summary is shortened. This was not quite necessary to fit in 80 > characters, as the upstream description is 76 characters, but the shortened > Summary is still reasonable and useful. > > -Summary: Serde traits only, with no support for derive -- use > the serde crate instead > +Summary: Serde traits Yes, I don't think anything after "Serde traits" is suitable for a public-facing description. > - A patch drops the serde_derive dependency. > > +# Manually created patch for downstream crate metadata changes > +# * temporarily drop noop serde_derive dependency > +Patch: serde_core-fix-metadata.diff > > This is reasonably well-documented, but I don’t really understand from the > description why the dependency needs to be dropped or what it means for it > to > be “noop.” A more descriptive comment would be nice. The dependency is a noop insofar as that it's only present for dependency resolution to force the same version for serde_core and serde_derive, but the dependency itself is actually disabled unconditionally being scoped with "cfg(any())". Also, if I *didn't* temporarily drop it, I wouldn't have been able to prepare this package - since it depends on a version of serde_derive that is *after* the serde / serde_core split, which I couldn't have updated to without serde_core being packaged. :) -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component https://bugzilla.redhat.com/show_bug.cgi?id=2395053 Report this comment as SPAM: https://bugzilla.redhat.com/enter_bug.cgi?product=Bugzilla&format=report-spam&short_desc=Report%20of%20Bug%202395053%23c4 -- _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
