https://bugzilla.redhat.com/show_bug.cgi?id=2374723 --- Comment #10 from Dominik 'Rathann' Mierzejewski <dominik@xxxxxxxxxxxxxx> --- Package Review ============== Legend: [x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated [ ] = Manual review needed Issues: ======= 1. systemd_user_post is not invoked in %post and systemd_user_preun in %preun for Systemd user units service files. Note: Systemd user unit service file(s) in mpd See: https://docs.fedoraproject.org/en-US/packaging-guidelines/Scriptlets/#_user_units -> please add the missing macro calls. 2. Directories without known owners: /etc/logrotate.d -> add %dir /etc/logrotate.d to %files mpd.x86_64: E: missing-dependency-to-logrotate for logrotate script /etc/logrotate.d/mpd -> add a dependency on logrotate (Recommends: if not strictly required) 3. [!]: Package consistently uses macros (instead of hard-coded directory names). > %{_prefix}/lib/tmpfiles.d/mpd.conf -> use %{_tmpfilesdir} > %{_datadir}/icons/hicolor/scalable/apps/mpd.svg -> use %{_iconsdir} 4. # Allow for privilege escalation when using systemd Patch1: mpd-0.24-remove_NoNewPrivileges.patch -> Why do you want to allow that? 5. [!]: Sources can be downloaded from URI in Source: tag Note: Could not download Source2: https://pgp.key- server.io/download/0x236E8A58C6DB4512#/gpgkey.asc See: https://docs.fedoraproject.org/en-US/packaging- guidelines/SourceURL/ Looks like key-server.io has expired and was bought by domain flippers. -> remove the URL 6. [!]: Latest version is packaged. -> Looks like 0.24.5 is out. ===== MUST items ===== C/C++: [x]: Package does not contain kernel modules. [x]: If your application is a C or C++ application you must list a BuildRequires against gcc, gcc-c++ or clang. [x]: Package does not contain any libtool archives (.la) [x]: Package contains no static executables. [x]: Rpath absent or only used for internal libs. Generic: [x]: Package successfully compiles and builds into binary rpms on at least one supported primary architecture. Note: Using prebuilt packages [x]: Package is licensed with an open-source compatible license and meets other legal requirements as defined in the legal section of Packaging Guidelines. [x]: License field in the package spec file matches the actual license. Note: Checking patched sources after %prep for licenses. Licenses found: "Unknown or generated", "GNU General Public License, Version 2", "*No copyright* GNU General Public License, Version 2", "*No copyright* BSD 2-Clause License", "ISC License", "GNU Lesser General Public License, Version 2.1", "Apache License 2.0", "BSD 2-Clause License", "BSD 2-Clause with views sentence", "GNU Lesser General Public License v2.1 or later", "*No copyright* ISC License". 225 files have unknown license. Detailed output of licensecheck in /var/lib/copr-rpmbuild/results/mpd/licensecheck.txt [x]: If the package is under multiple licenses, the licensing breakdown must be documented in the spec. [!]: Package must own all directories that it creates. Note: Directories without known owners: /etc/logrotate.d [x]: %build honors applicable compiler flags or justifies otherwise. [x]: Package contains no bundled libraries without FPC exception. [x]: Changelog in prescribed format. [x]: Sources contain only permissible code or content. [-]: Each %files section contains %defattr if rpm < 4.4 Note: %defattr present but not needed [-]: Package contains desktop file if it is a GUI application. [x]: Development files must be in a -devel package [x]: Package uses nothing in %doc for runtime. [!]: Package consistently uses macros (instead of hard-coded directory names). [x]: Package is named according to the Package Naming Guidelines. [x]: Package does not generate any conflict. [x]: Package obeys FHS, except libexecdir and /usr/target. [-]: If the package is a rename of another package, proper Obsoletes and Provides are present. [x]: Requires correct, justified where necessary. [!]: Spec file is legible and written in American English. [x]: Package contains systemd file(s) if in need. [x]: Useful -debuginfo package or justification otherwise. [x]: Package is not known to require an ExcludeArch tag. [x]: Large documentation must go in a -doc subpackage. Large could be size (~1MB) or number of files. Note: Documentation size is 100273 bytes in 3 files. [x]: Package complies to the Packaging Guidelines [x]: Package installs properly. [x]: Rpmlint is run on all rpms the build produces. Note: There are rpmlint messages (see attachment). [x]: If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package is included in %license. [x]: The License field must be a valid SPDX expression. [x]: Package requires other packages for directories it uses. [x]: Package does not own files or directories owned by other packages. [x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT [x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the beginning of %install. [x]: %config files are marked noreplace or the reason is justified. [x]: Macros in Summary, %description expandable at SRPM build time. [x]: Dist tag is present. [x]: Package does not contain duplicates in %files. [x]: Permissions on files are set properly. [x]: Package must not depend on deprecated() packages. [x]: Package use %makeinstall only when make install DESTDIR=... doesn't work. [x]: Package is named using only allowed ASCII characters. [x]: No %config files under /usr. [x]: Package does not use a name that already exists. [x]: Package is not relocatable. [x]: Sources used to build the package match the upstream source, as provided in the spec URL. [x]: Spec file name must match the spec package %{name}, in the format %{name}.spec. [x]: systemd_post is invoked in %post, systemd_preun in %preun, and systemd_postun in %postun for Systemd service files. Note: Systemd service file(s) in mpd [x]: File names are valid UTF-8. [x]: Packages must not store files under /srv, /opt or /usr/local ===== SHOULD items ===== Generic: [x]: Reviewer should test that the package builds in mock. [x]: Uses parallel make %{?_smp_mflags} macro. [!]: Sources can be downloaded from URI in Source: tag Note: Could not download Source2: https://pgp.key- server.io/download/0x236E8A58C6DB4512#/gpgkey.asc See: https://docs.fedoraproject.org/en-US/packaging- guidelines/SourceURL/ [-]: If the source package does not include license text(s) as a separate file from upstream, the packager SHOULD query upstream to include it. [x]: Final provides and requires are sane (see attachments). [x]: Package functions as described. [!]: Latest version is packaged. [x]: Package does not include license text files separate from upstream. [x]: Patches link to upstream bugs/comments/lists or are otherwise justified. [x]: Sources are verified with gpgverify first in %prep if upstream publishes signatures. Note: Sources 3, 4 and 5 are not passed to gpgverify. [x]: Package should compile and build into binary rpms on all supported architectures. [x]: %check is present and all tests pass. [x]: Packages should try to preserve timestamps of original installed files. [x]: Files in /run, var/run and /var/lock uses tmpfiles.d when appropriate [x]: Buildroot is not present [x]: Package has no %clean section with rm -rf %{buildroot} (or $RPM_BUILD_ROOT) [x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin. [x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file [x]: SourceX is a working URL. [x]: Spec use %global instead of %define unless justified. ===== EXTRA items ===== Generic: [x]: Rpmlint is run on debuginfo package(s). Note: No rpmlint messages. [x]: Rpmlint is run on all installed packages. Note: No rpmlint messages. [x]: Large data in /usr/share should live in a noarch subpackage if package is arched. Rpmlint ------- Checking: mpd-0.24.4-3.fc44.x86_64.rpm mpd-0.24.4-3.fc44.src.rpm ============================ rpmlint session starts ============================ rpmlint: 2.7.0 configuration: /usr/lib/python3.13/site-packages/rpmlint/configdefaults.toml /etc/xdg/rpmlint/fedora-spdx-licenses.toml /etc/xdg/rpmlint/fedora.toml /etc/xdg/rpmlint/scoring.toml /etc/xdg/rpmlint/users-groups.toml /etc/xdg/rpmlint/warn-on-functions.toml rpmlintrc: [PosixPath('/tmp/tmpc6nsvtsl')] checks: 32, packages: 2 mpd.x86_64: W: post-without-tmpfile-creation /usr/lib/tmpfiles.d/mpd.conf mpd.x86_64: W: non-standard-uid /run/mpd mpd mpd.x86_64: W: non-standard-uid /var/lib/mpd mpd mpd.x86_64: W: non-standard-uid /var/lib/mpd/mpd.db mpd mpd.x86_64: W: non-standard-uid /var/lib/mpd/mpdstate mpd mpd.x86_64: W: non-standard-uid /var/lib/mpd/music mpd mpd.x86_64: W: non-standard-uid /var/lib/mpd/playlists mpd mpd.x86_64: W: non-standard-uid /var/log/mpd mpd mpd.x86_64: W: non-standard-uid /var/log/mpd/mpd.log mpd mpd.x86_64: W: non-standard-gid /run/mpd mpd mpd.x86_64: W: non-standard-gid /var/lib/mpd mpd mpd.x86_64: W: non-standard-gid /var/lib/mpd/mpd.db mpd mpd.x86_64: W: non-standard-gid /var/lib/mpd/mpdstate mpd mpd.x86_64: W: non-standard-gid /var/lib/mpd/music mpd mpd.x86_64: W: non-standard-gid /var/lib/mpd/playlists mpd mpd.x86_64: W: non-standard-gid /var/log/mpd mpd mpd.x86_64: W: non-standard-gid /var/log/mpd/mpd.log mpd mpd.x86_64: E: missing-dependency-to-logrotate for logrotate script /etc/logrotate.d/mpd mpd.x86_64: E: logrotate-user-writable-log-dir /var/log/mpd mpd:mpd 0755 mpd.x86_64: E: incorrect-fsf-address /usr/share/licenses/mpd/COPYING mpd.x86_64: E: incorrect-fsf-address /usr/share/licenses/mpd/GPL-2.0-or-later.txt mpd.x86_64: E: incorrect-fsf-address /usr/share/licenses/mpd/LGPL-2.1-only.txt mpd.x86_64: W: files-duplicate /usr/lib/systemd/user/mpd.socket /usr/lib/systemd/system/mpd.socket 2 packages and 0 specfiles checked; 5 errors, 18 warnings, 13 filtered, 5 badness; has taken 0.4 s Rpmlint (debuginfo) ------------------- Checking: mpd-debuginfo-0.24.4-3.fc44.x86_64.rpm ============================ rpmlint session starts ============================ rpmlint: 2.7.0 configuration: /usr/lib/python3.13/site-packages/rpmlint/configdefaults.toml /etc/xdg/rpmlint/fedora-spdx-licenses.toml /etc/xdg/rpmlint/fedora.toml /etc/xdg/rpmlint/scoring.toml /etc/xdg/rpmlint/users-groups.toml /etc/xdg/rpmlint/warn-on-functions.toml rpmlintrc: [PosixPath('/tmp/tmpdh800501')] checks: 32, packages: 1 1 packages and 0 specfiles checked; 0 errors, 0 warnings, 5 filtered, 0 badness; has taken 1.2 s Rpmlint (installed packages) ---------------------------- (none): E: there is no installed rpm "mpd". (none): E: there is no installed rpm "mpd-debuginfo". There are no files to process nor additional arguments. Nothing to do, aborting. ============================ rpmlint session starts ============================ rpmlint: 2.7.0 configuration: /usr/lib/python3.14/site-packages/rpmlint/configdefaults.toml /etc/xdg/rpmlint/fedora-spdx-licenses.toml /etc/xdg/rpmlint/fedora.toml /etc/xdg/rpmlint/scoring.toml /etc/xdg/rpmlint/users-groups.toml /etc/xdg/rpmlint/warn-on-functions.toml checks: 32, packages: 2 0 packages and 0 specfiles checked; 0 errors, 0 warnings, 0 filtered, 0 badness; has taken 0.0 s Source checksums ---------------- https://www.musicpd.org//download/mpd/0.24/mpd-0.24.4.tar.xz.sig : CHECKSUM(SHA256) this package : 7cad895f4aedf7bc2731798cb2244530959a141a999ef72862d363d94bbe37ec CHECKSUM(SHA256) upstream package : 7cad895f4aedf7bc2731798cb2244530959a141a999ef72862d363d94bbe37ec https://www.musicpd.org//download/mpd/0.24/mpd-0.24.4.tar.xz : CHECKSUM(SHA256) this package : 86035d6c63af32afa77fd5eb5ecd1c6afaef7cc352b28064edf51eea60f40d66 CHECKSUM(SHA256) upstream package : 86035d6c63af32afa77fd5eb5ecd1c6afaef7cc352b28064edf51eea60f40d66 Requires -------- mpd (rpmlib, GLIBC filtered): /bin/sh config(mpd) group(audio) group(mpd) hicolor-icon-theme libFLAC.so.14()(64bit) libWildMidi.so.2()(64bit) libadplug-2.3.3.so.0()(64bit) libao.so.4()(64bit) libao.so.4(LIBAO4_1.1.0)(64bit) libasound.so.2()(64bit) libasound.so.2(ALSA_0.9)(64bit) libasound.so.2(ALSA_0.9.0)(64bit) libasound.so.2(ALSA_0.9.0rc4)(64bit) libaudiofile.so.1()(64bit) libavahi-client.so.3()(64bit) libavahi-common.so.3()(64bit) libavcodec.so.61()(64bit) libavcodec.so.61(LIBAVCODEC_61)(64bit) libavfilter.so.10()(64bit) libavfilter.so.10(LIBAVFILTER_10)(64bit) libavformat.so.61()(64bit) libavformat.so.61(LIBAVFORMAT_61)(64bit) libavutil.so.59()(64bit) libavutil.so.59(LIBAVUTIL_59)(64bit) libbz2.so.1()(64bit) libc.so.6()(64bit) libcdio.so.19()(64bit) libcdio.so.19(CDIO_19)(64bit) libcdio_cdda.so.2()(64bit) libcdio_cdda.so.2(CDIO_CDDA_2)(64bit) libcdio_paranoia.so.2()(64bit) libcdio_paranoia.so.2(CDIO_PARANOIA_2)(64bit) libchromaprint.so.1()(64bit) libcurl.so.4()(64bit) libdbus-1.so.3()(64bit) libdbus-1.so.3(LIBDBUS_1_3)(64bit) libexpat.so.1()(64bit) libfaad.so.2()(64bit) libfluidsynth.so.3()(64bit) libfmt.so.11()(64bit) libgcc_s.so.1()(64bit) libgcc_s.so.1(GCC_3.0)(64bit) libgcc_s.so.1(GCC_3.3.1)(64bit) libgme.so.0()(64bit) libicui18n.so.77()(64bit) libicuuc.so.77()(64bit) libid3tag.so.0()(64bit) libiso9660.so.11()(64bit) libiso9660.so.11(ISO9660_11)(64bit) libixml.so.11()(64bit) libjack.so.0()(64bit) libm.so.6()(64bit) libmad.so.0()(64bit) libmikmod.so.3()(64bit) libmms.so.0()(64bit) libmodplug.so.1()(64bit) libmp3lame.so.0()(64bit) libmpcdec.so.6()(64bit) libmpdclient.so.2()(64bit) libmpdclient.so.2(libmpdclient2)(64bit) libmpg123.so.0()(64bit) libnfs.so.16()(64bit) libogg.so.0()(64bit) libopenal.so.1()(64bit) libopenmpt.so.0()(64bit) libopus.so.0()(64bit) libpcre2-8.so.0()(64bit) libpipewire-0.3.so.0()(64bit) libpulse.so.0()(64bit) libpulse.so.0(PULSE_0)(64bit) libsamplerate.so.0()(64bit) libsamplerate.so.0(libsamplerate.so.0.0)(64bit) libshout.so.3()(64bit) libsidplayfp.so.6()(64bit) libsndfile.so.1()(64bit) libsndfile.so.1(libsndfile.so.1.0)(64bit) libsoxr.so.0()(64bit) libsqlite3.so.0()(64bit) libstdc++.so.6()(64bit) libstdc++.so.6(CXXABI_1.3)(64bit) libstdc++.so.6(CXXABI_1.3.11)(64bit) libstdc++.so.6(CXXABI_1.3.13)(64bit) libstdc++.so.6(CXXABI_1.3.15)(64bit) libstdc++.so.6(CXXABI_1.3.3)(64bit) libstdc++.so.6(CXXABI_1.3.5)(64bit) libstdc++.so.6(CXXABI_1.3.8)(64bit) libstdc++.so.6(CXXABI_1.3.9)(64bit) libsystemd.so.0()(64bit) libsystemd.so.0(LIBSYSTEMD_209)(64bit) libtwolame.so.0()(64bit) libupnp.so.17()(64bit) liburing.so.2()(64bit) liburing.so.2(LIBURING_2.0)(64bit) liburing.so.2(LIBURING_2.2)(64bit) libvorbis.so.0()(64bit) libvorbisenc.so.2()(64bit) libwavpack.so.1()(64bit) libz.so.1()(64bit) libzzip-0.so.13()(64bit) rtld(GNU_HASH) user(mpd) Provides -------- mpd: config(mpd) group(mpd) groupmember(mpd/audio) mpd mpd(x86-64) user(mpd) Generated by fedora-review 0.10.0 (e79b66b) last change: 2023-07-24 Command line :/bin/fedora-review --no-colors --prebuilt --rpm-spec --name mpd --mock-config /var/lib/copr-rpmbuild/results/configs/child.cfg Buildroot used: fedora-rawhide-x86_64 Active plugins: Shell-api, Generic, C/C++ Disabled plugins: Ocaml, R, fonts, Haskell, SugarActivity, Perl, PHP, Java, Python Disabled flags: EXARCH, EPEL6, EPEL7, DISTTAG, BATCH -- You are receiving this mail because: You are always notified about changes to this product and component You are on the CC list for the bug. https://bugzilla.redhat.com/show_bug.cgi?id=2374723 Report this comment as SPAM: https://bugzilla.redhat.com/enter_bug.cgi?product=Bugzilla&format=report-spam&short_desc=Report%20of%20Bug%202374723%23c10 -- _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
