https://bugzilla.redhat.com/show_bug.cgi?id=2389251 --- Comment #2 from Dominik 'Rathann' Mierzejewski <dominik@xxxxxxxxxxxxxx> --- 1. Is there a particular reason why you can't replace: %setup -q -n dave_gnukem-%{version} %setup -q -n dave_gnukem-%{version} -D -T -a 1 with %setup -q -n dave_gnukem-%{version} -a 1 ? 2. Is there any particular reason to use double hyphen instead of a single one in patch file names? Patch0: gnukem--Makefile.patch Patch1: gnukem--BigEndian.patch 3. %{_mandir}/man6/%{name}.* Shouldn't this be: %{_mandir}/man6/%{name}.6* ? -- You are receiving this mail because: You are always notified about changes to this product and component You are on the CC list for the bug. https://bugzilla.redhat.com/show_bug.cgi?id=2389251 Report this comment as SPAM: https://bugzilla.redhat.com/enter_bug.cgi?product=Bugzilla&format=report-spam&short_desc=Report%20of%20Bug%202389251%23c2 -- _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
