https://bugzilla.redhat.com/show_bug.cgi?id=2386905 --- Comment #5 from Ken Giusti <kgiusti@xxxxxxxxxx> --- (In reply to Mikel Olasagasti Uranga from comment #4) > I'm adding a couple of comments as Go-SIG member. > > > # Generated by go2rpm 1.16.0 > > Can you update to use latest 1.17.1 template? > > > %if %{defined rhel} || "%{_arch}" == "i386" > > With "%gometa -L -f" arch i386 is already excluded, the check could be > removed. > > Once imported, please, give go-sig group privileges (at least commit) on the > package. Done - thanks Mikel! SRPM: https://download.copr.fedorainfracloud.org/results/kgiusti/go-fdo-client/srpm-builds/09441188/go-fdo-client-0-0.1.20250818git837c3ac.fc42.src.rpm Specfile: https://github.com/kgiusti/go-fdo-packaging/blob/main/fedora/client/go-fdo-client.spec Diff: ``` diff --git a/fedora/client/go-fdo-client.spec b/fedora/client/go-fdo-client.spec index a2011db..96a8bd4 100644 --- a/fedora/client/go-fdo-client.spec +++ b/fedora/client/go-fdo-client.spec @@ -1,12 +1,6 @@ -# Generated by go2rpm 1.16.0 +# Generated by go2rpm 1.17.1 %bcond check 1 -# scancode has a lot of dependencies, so it can be disabled for a faster build -# or when its deps are unavailable. -%if %{defined rhel} || "%{_arch}" == "i386" -%global go_vendor_license_check_disable 1 -%endif - # https://github.com/fido-device-onboard/go-fdo-client %global goipath github.com/fido-device-onboard/go-fdo-client %global commit 837c3aca86a3d44344f7edd5703cf13adfc22fc2 @@ -56,7 +50,7 @@ install -m 0755 -vp %{gobuilddir}/bin/* %{buildroot}%{_bindir}/ %check %go_vendor_license_check -c %{S:2} %if %{with check} -%gocheck +%gotest ./... %endif %files -f %{go_vendor_license_filelist} ``` Question: rpmlint is complaining about a few things that appear to be related to the vendored code: go-fdo-client.x86_64: W: files-duplicate /usr/share/licenses/go-fdo-client/vendor/github.com/fido-device-onboard/go-fdo/tpm/LICENSE /usr/share/licenses/go-fdo-client/LICENSE:/usr/share/licenses/go-fdo-client/vendor/github.com/fido-device-onboard/go-fdo/LICENSE:/usr/share/licenses/go-fdo-client/vendor/github.com/fido-device-onboard/go-fdo/fsim/LICENSE go-fdo-client.x86_64: W: files-duplicate /usr/share/licenses/go-fdo-client/vendor/golang.org/x/term/LICENSE /usr/share/licenses/go-fdo-client/vendor/golang.org/x/sys/LICENSE go-fdo-client.x86_64: W: files-duplicate /usr/share/licenses/go-fdo-client/vendor/golang.org/x/term/PATENTS /usr/share/licenses/go-fdo-client/vendor/golang.org/x/sys/PATENTS These are in fact duplicate but across (and within) some of the vendored packages. Is there a recommended way to fix this? Thanks -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component https://bugzilla.redhat.com/show_bug.cgi?id=2386905 Report this comment as SPAM: https://bugzilla.redhat.com/enter_bug.cgi?product=Bugzilla&format=report-spam&short_desc=Report%20of%20Bug%202386905%23c5 -- _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
