https://bugzilla.redhat.com/show_bug.cgi?id=2386079 --- Comment #9 from Luya Tshimbalanga <luya_tfz@xxxxxxxxxxxxxxxx> --- (In reply to Benson Muite from comment #8) > b) Please use > > ExcludeArch: i686 > > rather than listing architectures to be included. Done. That review line "Package is not known to require an ExcludeArch tag." was ambiguous though. > > c) An example with pytest and documentation is at: > > https://copr.fedorainfracloud.org/coprs/fed500/manifold/build/9413161/ > > This builds the package twice as the Python package build is a little > different than the regular > build. Perhaps another way can be found to build the Python package > metadata, for example by > adding an option to the CMakeLists.txt files to build a Python wheel. I am unsure how to do with CMakeList due to limited option for Python. The example of pytest seems working as intended. > > d) Maybe patches can be applied to clipper2 to enable shared versions of > clipper2utils to be built: > https://github.com/AngusJohnson/Clipper2/blob/main/CPP/CMakeLists.txt#L135 > https://github.com/AngusJohnson/Clipper2/blob/main/CPP/CMakeLists.txt#L142 > This is not blocking, but would be nice if possible at some point in future. Definitely after packaging review. > > e) Consider reporting S390x test failure upstream: > https://koji.fedoraproject.org/koji/taskinfo?taskID=136040145 Report filed upstream: https://github.com/elalish/manifold/issues/1335 Here is the updated SPEC: https://download.copr.fedorainfracloud.org/results/@designsuite/blender/fedora-rawhide-x86_64/09418401-manifold/manifold.spec SRPM: https://download.copr.fedorainfracloud.org/results/@designsuite/blender/fedora-rawhide-x86_64/09418401-manifold/manifold-3.2.1-1.fc44.src.rpm -- You are receiving this mail because: You are always notified about changes to this product and component You are on the CC list for the bug. https://bugzilla.redhat.com/show_bug.cgi?id=2386079 Report this comment as SPAM: https://bugzilla.redhat.com/enter_bug.cgi?product=Bugzilla&format=report-spam&short_desc=Report%20of%20Bug%202386079%23c9 -- _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
