[Bug 2378912] Review Request: jfrog-cli - JFrog CLI is a client that provides a simple interface that automates access to the JFrog products

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



https://bugzilla.redhat.com/show_bug.cgi?id=2378912



--- Comment #7 from Dominik 'Rathann' Mierzejewski <dominik@xxxxxxxxxxxxxx> ---
(In reply to Mikel Olasagasti Uranga from comment #6)
> Thanks for updating the spec!
> 
> > E: summary-too-long JFrog CLI is a client that provides a simple interface that automates access to the JFrog products
> 
> Something like this might be OK: CLI to automate access to JFrog products

Fixed.

> > %{_bindir}/jfrog-cli
> 
> Upstream uses `jf` for the binary, why not in this case? I can't find any
> other app using `jf` with `dnf provides /usr/bin/jf`.

Corrected. It used to be called jfrog-cli and I kept the name for no good
reason.

> Also, it seems this CLI supports shell completions, can you add them?
> https://docs.jfrog-applications.jfrog.io/jfrog-applications/jfrog-cli/shell-
> auto-completion

How? I get an error if I add this to the %build section:
for cmd in completion/shells; do
  %gobuild -o %{gobuilddir}/bin/$(basename $cmd) %{goipath}/$cmd
done

...
github.com/jfrog/jfrog-cli/completion/shells: build constraints exclude all Go
files in
/builddir/build/BUILD/jfrog-cli-2.78.3-build/jfrog-cli-2.78.3/completion/shells


-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
https://bugzilla.redhat.com/show_bug.cgi?id=2378912

Report this comment as SPAM: https://bugzilla.redhat.com/enter_bug.cgi?product=Bugzilla&format=report-spam&short_desc=Report%20of%20Bug%202378912%23c7

-- 
_______________________________________________
package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx
To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx
Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx
Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue




[Index of Archives]     [Fedora Users]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite Conditions]     [KDE Users]

  Powered by Linux