https://bugzilla.redhat.com/show_bug.cgi?id=2386164 David Auer <dreua@xxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |dreua@xxxxxxxxx --- Comment #1 from David Auer <dreua@xxxxxxxxx> --- Some thoughts: 1) The description doesn't do a great job explaining what the package does to someone without prior knowledge. Maybe start with something along the lines of "Python library for the reading and writing of embroidery files." (From the project's readme.) 2) From the current state of the upstream repo it looks like wouldn't be packaging the latest version. I saw that there is an issue about it but I think this really needs to be cleaned upstream to avoid further confusion. (I'd consider that a blocker for now.) 3) Why are you downloading the source by git commit instead of version tags? I don't know whether there are rules about it but it seems unnecessarily complex, harder for review and error prone for future updates. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component https://bugzilla.redhat.com/show_bug.cgi?id=2386164 Report this comment as SPAM: https://bugzilla.redhat.com/enter_bug.cgi?product=Bugzilla&format=report-spam&short_desc=Report%20of%20Bug%202386164%23c1 -- _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
