https://bugzilla.redhat.com/show_bug.cgi?id=2387625 --- Comment #3 from Neal Gompa <ngompa13@xxxxxxxxx> --- Spec review notes: > Source: %{url}/-/archive/v%{version}/%{name}-v%{version}.tar.gz > Source: https://gitlab.gnome.org/GNOME/gvdb/-/archive/%{gvdb_commit}/gvdb-%{gvdb_commit}.tar.gz Please number your sources, since you have multiple ones. It may not be required, but it makes it more coherent. > ExcludeArch: i686 This should be "ExcludeArch: %{ix86}" > %autosetup -a1 -n %{name}-v%{version} > mv gvdb-%{gvdb_commit} subprojects/gvdb This can be simplified to the following: %autosetup -n %{name}-v%{version} tar -xf %{S:1} -C subprojects/gvdb > %files -n libcellbroadcast-devel > %{_includedir}/libcellbroadcast-0.0/ > %{_libdir}/libcellbroadcast-0.0.so > %{_libdir}/pkgconfig/libcellbroadcast-0.0.pc > %changelog > %autochangelog This is missing a newline after the last files entry to separate sections. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component https://bugzilla.redhat.com/show_bug.cgi?id=2387625 Report this comment as SPAM: https://bugzilla.redhat.com/enter_bug.cgi?product=Bugzilla&format=report-spam&short_desc=Report%20of%20Bug%202387625%23c3 -- _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
