https://bugzilla.redhat.com/show_bug.cgi?id=2378912 --- Comment #12 from Dominik 'Rathann' Mierzejewski <dominik@xxxxxxxxxxxxxx> --- (In reply to Mikel Olasagasti Uranga from comment #11) > > Corrected. It used to be called jfrog-cli and I kept the name for no good reason. > > You can create a soft-link if you want to have both names. `node-exporter` > does that for example to keep old name. No need. Since this is a new package to Fedora, I'll just follow current upstream naming. > > How? I get an error if I add this to the %build section: > > for cmd in completion/shells; do > > %gobuild -o %{gobuilddir}/bin/$(basename $cmd) %{goipath}/$cmd > > done > > > > ... > > github.com/jfrog/jfrog-cli/completion/shells: build constraints exclude all Go files in /builddir/build/BUILD/jfrog-cli-2.78.3-build/jfrog-cli-2.78.3/completion/shells > > Can you try the way `doctl` spec does? > > in %build: > > %{gobuilddir}/bin/jf completion bash > jf.bash > %{gobuilddir}/bin/jf completion fish > jf.fish > %{gobuilddir}/bin/jf completion zsh > jf.zsh > > https://src.fedoraproject.org/rpms/doctl/blob/rawhide/f/doctl.spec#_51 Thanks for the pointer. Done! Spec URL: https://rathann.fedorapeople.org/review/jfrog-cli/jfrog-cli.spec SRPM URL: https://rathann.fedorapeople.org/review/jfrog-cli/jfrog-cli-2.78.3-3.fc44.src.rpm -- You are receiving this mail because: You are always notified about changes to this product and component You are on the CC list for the bug. https://bugzilla.redhat.com/show_bug.cgi?id=2378912 Report this comment as SPAM: https://bugzilla.redhat.com/enter_bug.cgi?product=Bugzilla&format=report-spam&short_desc=Report%20of%20Bug%202378912%23c12 -- _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
