[Bug 2386523] Review Request: python-aeidon - Library for reading, writing, and manipulating subtitle files

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



https://bugzilla.redhat.com/show_bug.cgi?id=2386523



--- Comment #17 from Parag AN(पराग) <panemade@xxxxxxxxx> ---
Still missing few things
1) in %prep section add
rm -rf .egg-info

2) add in SPEC above %prep line
generate_buildrequires
%pyproject_buildrequires

3) Remove any BuildRequires: and Requires: line first and add only
BuildRequires:  pyproject-rpm-macros
BuildRequires:  gettext

4) I suggest adding below BuildRequires line
Obsoletes: python3-aeidon < 1.15-23

5) in %install section before removal lines add explanation why removing
installed files like
# As this package is split from gaupol, we don't
# need gaupol package related files to be installed


Update the SPEC and SRPM


-- 
You are receiving this mail because:
You are always notified about changes to this product and component
You are on the CC list for the bug.
https://bugzilla.redhat.com/show_bug.cgi?id=2386523

Report this comment as SPAM: https://bugzilla.redhat.com/enter_bug.cgi?product=Bugzilla&format=report-spam&short_desc=Report%20of%20Bug%202386523%23c17

-- 
_______________________________________________
package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx
To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx
Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx
Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue




[Index of Archives]     [Fedora Users]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite Conditions]     [KDE Users]

  Powered by Linux