https://bugzilla.redhat.com/show_bug.cgi?id=2363931 Jitka Plesnikova <jplesnik@xxxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Flags|fedora-review? |fedora-review+ --- Comment #8 from Jitka Plesnikova <jplesnik@xxxxxxxxxx> --- (In reply to Charles R. Anderson from comment #3) > (In reply to Jitka Plesnikova from comment #2) > > FIX: Add build-require 'coreutils' it is needed for %{_fixperms} > > TODO: Please replace perl-blib by 'perl(blib)' > > TODO: Please add version restriction for perl(ExtUtils::MakeMaker) >= 6.76 > > NO_PACKLIST is provided since this version. > > FIX: Please remove duplicit run-requires: > > - perl(Exporter) >= 5.57 > > - perl(ExtUtils::MakeMaker) >= 6.68 > > - perl(List::Util) >= 1.45 > > FIX: Please add run-requires > > - perl(Data::Dumper) - lib/ExtUtils/Builder/Action/Command.pm:19 > > - perl(Perl::OSType) - lib/ExtUtils/Builder/MakeMaker.pm:63 > > TODO: Explicitly name packaged files in %{_mandir}/man* and > > %{perl_vendorlib} directories > > The above items are all fixed: 10a11 + BuildRequires: coreutils 12c13 - BuildRequires: perl-blib --- + BuildRequires: perl(blib) 23c24 - BuildRequires: perl(ExtUtils::MakeMaker) >= 6.68 --- + BuildRequires: perl(ExtUtils::MakeMaker) >= 6.76 43,45d43 - Requires: perl(Exporter) >= 5.57 - Requires: perl(ExtUtils::MakeMaker) >= 6.68 - Requires: perl(List::Util) >= 1.45 46a45,46 + Requires: perl(Data::Dumper) + Requires: perl(Perl::OSType) 73,74c73,76 - %{perl_vendorlib}/* - %{_mandir}/man3/* --- + %dir %{perl_vendorlib}/ExtUtils + %{perl_vendorlib}/ExtUtils/Builder.pm + %{perl_vendorlib}/ExtUtils/Builder + %{_mandir}/man3/ExtUtils::Builder* The changes look good. Resolution: Approved -- You are receiving this mail because: You are always notified about changes to this product and component You are on the CC list for the bug. https://bugzilla.redhat.com/show_bug.cgi?id=2363931 Report this comment as SPAM: https://bugzilla.redhat.com/enter_bug.cgi?product=Bugzilla&format=report-spam&short_desc=Report%20of%20Bug%202363931%23c8 -- _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
