https://bugzilla.redhat.com/show_bug.cgi?id=2382097 --- Comment #2 from Tom.Rix@xxxxxxx --- Spec URL: https://trix.fedorapeople.org/rocprofiler-register.spec SRPM URL: https://trix.fedorapeople.org/rocprofiler-register-6.4.3-1.fc43.src.rpm For the update. - Since glog is bundled, the license field should include BSD3 License: MIT AND BSD-3-Clause - I would install "external/glog/COPYING" as LICENSE.glog or similar # Copy glog's license file cp -p external/glog/COPYING COPYING.glog %license LICENSE COPYING.glog I choose COPYING.glog because the original file was COPYING. - mixed tabs and spaces (looks like a tab inserted by mistake), rpmlint output: rocprofiler-register.spec:27: W: mixed-use-of-spaces-and-tabs (spaces: line 27, tab: line 23) fixed a few other whitespace nits cleaned up. [x]: Latest version is packaged. > 6.4.3 is latest, but the git tag is the same as 6.4.1 %global rocm_release 6.4 %global rocm_patch 3 May as well use the latest tarball. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component https://bugzilla.redhat.com/show_bug.cgi?id=2382097 Report this comment as SPAM: https://bugzilla.redhat.com/enter_bug.cgi?product=Bugzilla&format=report-spam&short_desc=Report%20of%20Bug%202382097%23c2 -- _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
