https://bugzilla.redhat.com/show_bug.cgi?id=2376217 --- Comment #32 from Dave Dykstra <dwd@xxxxxxx> --- > You should be able to pass `-gcflags` directly to the %gobuild macro. It works for me everywhere except el10 where I get an error Unknown option g in gobuild(o:) Oh well, I changed it to pass the option anyway when debug is enabled, because currently I don't have a need to enable it on el10 and presumably it will eventually catch up. (I ended up with two different %gobuild lines because %{?GO_BUILD_GCFLAGS:-gcflags "${GO_BUILD_GCFLAGS}"} did not work as I expected and didn't pass anything even when GO_BUILD_GCFLAGS was defined). > relying on GO111MODULE=on that doesn't require this is also an option Ok I'll stick with that option then. I included a comment to say why. > Otherwise, please add a comment explaining that tests cannot be run. Done. > I would surround the entire scriptlet (including the %pre part) in a conditional I did that but later removed it because I switched to %sysusers_create_compat. > when the manual %pre scriptlet is in use, you need to include "Requires(pre): shadow-utils." Ok. That's now done with %{?sysusers_requires_compat}. > The sysusers macros were backported to epel-rpm-macros in epel8, but they don't seem to exist on epel9. No, they're there in the systemd-rpm-macros. I switched to using them. > caps ... and please include a comment about why this is necessary for the sake of anyone auditing the package. Thanks for asking about that, because I found out that openbao removed the need for it, so I removed it. Rationale is at https://openbao.org/docs/rfcs/mlock-removal/. > You should also remove the explicit dependencies on epel-rpm-macros and rpmautospec-rpm-macros. Done > Also, how are the bundled() Provides generated? This needs to be documented (a specfile comment is fine). It is done with an awk/sed pipeline in the make-spec script that reads from go.mod. Comment added. > Can you please include the Spec URL and SRPM URL in the following format after each change Ok. Spec URL: https://raw.githubusercontent.com/opensciencegrid/openbao-rpm/refs/tags/v2.3.2/openbao.spec SRPM URL: https://github.com/opensciencegrid/openbao-rpm/releases/download/v2.3.2/openbao-2.3.2-1.src.rpm Copr build: https://copr.fedorainfracloud.org/coprs/dwd/openbao/build/9493010/ -- You are receiving this mail because: You are always notified about changes to this product and component You are on the CC list for the bug. https://bugzilla.redhat.com/show_bug.cgi?id=2376217 Report this comment as SPAM: https://bugzilla.redhat.com/enter_bug.cgi?product=Bugzilla&format=report-spam&short_desc=Report%20of%20Bug%202376217%23c32 -- _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
