https://bugzilla.redhat.com/show_bug.cgi?id=2386724 Mikel Olasagasti Uranga <mikel@xxxxxxxxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED CC| |mikel@xxxxxxxxxxxxxxx --- Comment #10 from Mikel Olasagasti Uranga <mikel@xxxxxxxxxxxxxxx> --- You're missing the following: -X github.com/jandedobbeleer/oh-my-posh/src/build.Version={{ .Version }} -X github.com/jandedobbeleer/oh-my-posh/src/build.Date={{ .Date }} $ oh-my-posh --version 0.0.0-dev Add this after the gomodulesmode: export GO_LDFLAGS="-X github.com/jandedobbeleer/oh-my-posh/src/build.Version=%{version} \ -X github.com/jandedobbeleer/oh-my-posh/src/build.Date=$(date -d "@${SOURCE_DATE_EPOCH}" +%Y-%m-%d) - Remove the following: > # crashing build due to file not found - Is this provide required? Rest of distributions name it `oh-my-posh` and I see no reference for `ohmyposh`. > Provides: ohmyposh = %{version}-%{release} > #alias Extra non-required things: - Do you plan to package Nerd Fonts? - shell completions are disabled after this patch https://github.com/JanDeDobbeleer/oh-my-posh/pull/6122/commits/64bd60dc069caeaf434621dbd680b3d05cdf55e8 but as they're provided by Cobra directly maybe they can be included in the package as downstream feature. - Is there any way to disable the upgrade module with a default config or buildtag? Chezmoi can do this with a `noupgrade` buildtag for example: https://www.chezmoi.io/developer-guide/packaging/ -- You are receiving this mail because: You are always notified about changes to this product and component You are on the CC list for the bug. https://bugzilla.redhat.com/show_bug.cgi?id=2386724 Report this comment as SPAM: https://bugzilla.redhat.com/enter_bug.cgi?product=Bugzilla&format=report-spam&short_desc=Report%20of%20Bug%202386724%23c10 -- _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
