https://bugzilla.redhat.com/show_bug.cgi?id=2388375 --- Comment #59 from Cristian Le <fedora@xxxxxxxxx> --- Regarding the SRPM, it is indeed bundling the correct Source0, but as you might have noticed, the build is not successful. The logs seem to indicate that the patch was not packaged in the SRPM, but I am able to see it in there (tip, your desktop archive program should be able to open it and you would be able to navigate through it, at least for me ark does that nicely). I suspect the logs are outdated. But even so, looking at the patch, it would not apply successfully because it does not appear to be created against the correct initial files [1]. Recommendation is to recreate the patch from scratch again. Normally I would also recommend not to do the `rm ez_setup.py` inside the patch because this is a persistent change that you would carry, and instead have it inside the spec file, but not a blocker for this case because the upstream is dead. Regarding the AI discussion, I would hope that drafting there would be word drafting and not code/implementation drafting, in which case, it would be fine, although we are perfectly fine with your natural speech. There are plenty of contributors with varying English capabilities and I find that it is more easy to pick up on what someone was truly trying to say when there is no transcriber in the middle. And again, feel free to just message me directly in the matrix room or anyone in the devel chatroom when you are stuck or don't quite understand something. We are more than happy to chime in and help on small issues. Package reviews take a bit more effort to navigate what was changed, what's the status, etc., quick messages in the chatroom on the other hand is much easier to hop in and out as we randomly find the time for it. [1]: https://github.com/redadmin-k/gshogi-fedora44/blob/610c207fbfb73b7d02ffa1faad88fcf358e2e508/0001-drop-data_files-and-ez_setup.patch#L442-L447 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component https://bugzilla.redhat.com/show_bug.cgi?id=2388375 Report this comment as SPAM: https://bugzilla.redhat.com/enter_bug.cgi?product=Bugzilla&format=report-spam&short_desc=Report%20of%20Bug%202388375%23c59 -- _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
